Skip to content

feat: withdrawals status sync#679

Merged
shumkov merged 193 commits intov0.24-devfrom
feat/withdrawal-sync
Feb 18, 2023
Merged

feat: withdrawals status sync#679
shumkov merged 193 commits intov0.24-devfrom
feat/withdrawal-sync

Conversation

@jawid-h
Copy link
Copy Markdown
Contributor

@jawid-h jawid-h commented Dec 18, 2022

Issue being fixed or feature implemented

As per document this PR implements Withdrawal Document creation and sync process

What was done?

  • updated ABCI handlers
  • updated apply process of the IdentityCreditWithdrawalStateTransition

How Has This Been Tested?

  • unit testing

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorer
QuantumExplorer reviewed Feb 17, 2023
View reviewed changes
Comment thread packages/rs-dpp/src/tests/fixtures/get_documents_fixture.rs Outdated
QuantumExplorer
QuantumExplorer reviewed Feb 17, 2023
View reviewed changes
Comment thread packages/rs-drive/src/rpc/mod.rs
@shumkov
Copy link
Copy Markdown
Collaborator

shumkov commented Feb 17, 2023

  • coreFeePerByte -> coreFee. set minus whole coreFee amount from balance
  • update multiple transactions to broadcasted
  • set identityId as withdrawal document’s ownerId
  • fetch withdrawal documents for status update by status only
  • deal with features

shumkov
shumkov requested changes Feb 17, 2023
View reviewed changes
Comment thread ...identity_credit_withdrawal_transition/apply_identity_credit_withdrawal_transition_factory.rs Outdated
Comment thread .github/workflows/rs-checks.yml Outdated
@jawid-h jawid-h requested a review from shumkov February 17, 2023 14:11
shumkov
shumkov previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! 🥳 Approved!

@shumkov shumkov dismissed QuantumExplorer’s stale review February 17, 2023 15:09

We got approval verbally

shumkov
shumkov previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again 👍

@shumkov shumkov merged commit 6b35afc into v0.24-dev Feb 18, 2023
@shumkov shumkov deleted the feat/withdrawal-sync branch February 18, 2023 01:34
@lklimek lklimek mentioned this pull request Apr 24, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees

@shumkov shumkov

@QuantumExplorer QuantumExplorer

@jawid-h jawid-h

Labels

None yet

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jawid-h @shumkov @QuantumExplorer @thephez